X-Git-Url: https://git.lukelau.me/?a=blobdiff_plain;f=src%2FLanguage%2FHaskell%2FLSP%2FTest%2FCompat.hs;h=ddf4a7893e9c4a635a007b91981e6077bfa6c86b;hb=b9125dab0726c05597d9dd372e12f779906c5b5b;hp=6b018cce5a526e7e111d459d3bd3b68d3d21ed09;hpb=502c8dc3ff63383487536922176330a3f459a462;p=lsp-test.git diff --git a/src/Language/Haskell/LSP/Test/Compat.hs b/src/Language/Haskell/LSP/Test/Compat.hs index 6b018cc..ddf4a78 100644 --- a/src/Language/Haskell/LSP/Test/Compat.hs +++ b/src/Language/Haskell/LSP/Test/Compat.hs @@ -5,14 +5,12 @@ {-# OPTIONS_GHC -Wunused-imports #-} module Language.Haskell.LSP.Test.Compat where -import Control.Concurrent.Chan -import Control.Monad.IO.Class -import Data.Conduit import Data.Maybe +import System.IO #if MIN_VERSION_process(1,6,3) -import System.Process hiding (getPid) -import qualified System.Process (getPid) +import System.Process hiding (getPid, cleanupProcess) +import qualified System.Process (getPid, cleanupProcess) #else import System.Process import System.Process.Internals @@ -39,7 +37,11 @@ getProcessID p = fromIntegral . fromJust <$> getProcessID' p #if MIN_VERSION_process(1,6,3) getProcessID' = System.Process.getPid #else +#if MIN_VERSION_process(1,6,0) getProcessID' (ProcessHandle mh _ _) = do +#else + getProcessID' (ProcessHandle mh _) = do +#endif p_ <- readMVar mh case p_ of #ifdef mingw32_HOST_OS @@ -52,12 +54,23 @@ getProcessID p = fromIntegral . fromJust <$> getProcessID' p _ -> return Nothing #endif -#if MIN_VERSION_conduit(1,3,0) -chanSource :: MonadIO m => Chan o -> ConduitT i o m b +cleanupRunningProcess :: (Maybe Handle, Maybe Handle, Maybe Handle, ProcessHandle) -> IO () +cleanupRunningProcess p@(_, _, _, ph) = + getProcessExitCode ph >>= maybe (cleanupProcess p) (const $ return ()) + +cleanupProcess :: (Maybe Handle, Maybe Handle, Maybe Handle, ProcessHandle) -> IO () +#if MIN_VERSION_process(1,6,3) +cleanupProcess = System.Process.cleanupProcess #else -chanSource :: MonadIO m => Chan o -> ConduitM i o m b +cleanupProcess (mb_stdin, mb_stdout, mb_stderr, ph) = do + + terminateProcess ph + -- Note, it's important that other threads that might be reading/writing + -- these handles also get killed off, since otherwise they might be holding + -- the handle lock and prevent us from closing, leading to deadlock. + maybe (return ()) hClose mb_stdin + maybe (return ()) hClose mb_stdout + maybe (return ()) hClose mb_stderr + + return () #endif -chanSource c = do - x <- liftIO $ readChan c - yield x - chanSource c