From 502c8dc3ff63383487536922176330a3f459a462 Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Fri, 22 Jun 2018 19:48:57 +0100 Subject: [PATCH] Remove dependency on process-1.6.3 --- haskell-lsp-test.cabal | 2 +- src/Language/Haskell/LSP/Test.hs | 2 +- src/Language/Haskell/LSP/Test/Compat.hs | 44 +++++++++++++++++++----- src/Language/Haskell/LSP/Test/Server.hs | 4 +-- src/Language/Haskell/LSP/Test/Session.hs | 2 +- 5 files changed, 41 insertions(+), 13 deletions(-) diff --git a/haskell-lsp-test.cabal b/haskell-lsp-test.cabal index 42171da..510b758 100644 --- a/haskell-lsp-test.cabal +++ b/haskell-lsp-test.cabal @@ -33,7 +33,7 @@ library , lens , mtl , parser-combinators - , process >= 1.6.3 + , process , text , transformers , unordered-containers diff --git a/src/Language/Haskell/LSP/Test.hs b/src/Language/Haskell/LSP/Test.hs index 8da170c..3331c09 100644 --- a/src/Language/Haskell/LSP/Test.hs +++ b/src/Language/Haskell/LSP/Test.hs @@ -106,7 +106,7 @@ runSessionWithConfig :: SessionConfig -- ^ The capabilities the client should ha -> Session a -- ^ The session to run. -> IO a runSessionWithConfig config serverExe rootDir session = do - pid <- getProcessID + pid <- getCurrentProcessID absRootDir <- canonicalizePath rootDir let initializeParams = InitializeParams (Just pid) diff --git a/src/Language/Haskell/LSP/Test/Compat.hs b/src/Language/Haskell/LSP/Test/Compat.hs index 2372b09..6b018cc 100644 --- a/src/Language/Haskell/LSP/Test/Compat.hs +++ b/src/Language/Haskell/LSP/Test/Compat.hs @@ -8,19 +8,48 @@ module Language.Haskell.LSP.Test.Compat where import Control.Concurrent.Chan import Control.Monad.IO.Class import Data.Conduit +import Data.Maybe + +#if MIN_VERSION_process(1,6,3) +import System.Process hiding (getPid) +import qualified System.Process (getPid) +#else +import System.Process +import System.Process.Internals +import Control.Concurrent.MVar +#endif #ifdef mingw32_HOST_OS +import qualified System.Win32.Process +#else +import qualified System.Posix.Process +#endif -import qualified System.Win32.Process as P (getCurrentProcessId) -getProcessID :: IO Int -getProcessID = fromIntegral <$> P.getCurrentProcessId +getCurrentProcessID :: IO Int +#ifdef mingw32_HOST_OS +getCurrentProcessID = fromIntegral <$> System.Win32.Process.getCurrentProcessId #else +getCurrentProcessID = fromIntegral <$> System.Posix.Process.getProcessID +#endif -import qualified System.Posix.Process as P (getProcessID) -getProcessID :: IO Int -getProcessID = fromIntegral <$> P.getProcessID - +getProcessID :: ProcessHandle -> IO Int +getProcessID p = fromIntegral . fromJust <$> getProcessID' p + where +#if MIN_VERSION_process(1,6,3) + getProcessID' = System.Process.getPid +#else + getProcessID' (ProcessHandle mh _ _) = do + p_ <- readMVar mh + case p_ of +#ifdef mingw32_HOST_OS + OpenHandle h -> do + pid <- System.Win32.Process.getProcessId h + return $ Just pid +#else + OpenHandle pid -> return $ Just pid +#endif + _ -> return Nothing #endif #if MIN_VERSION_conduit(1,3,0) @@ -32,4 +61,3 @@ chanSource c = do x <- liftIO $ readChan c yield x chanSource c - \ No newline at end of file diff --git a/src/Language/Haskell/LSP/Test/Server.hs b/src/Language/Haskell/LSP/Test/Server.hs index 473f2c7..c59a755 100644 --- a/src/Language/Haskell/LSP/Test/Server.hs +++ b/src/Language/Haskell/LSP/Test/Server.hs @@ -2,7 +2,7 @@ module Language.Haskell.LSP.Test.Server (withServer) where import Control.Concurrent import Control.Monad -import Data.Maybe +import Language.Haskell.LSP.Test.Compat import System.IO import System.Process @@ -19,7 +19,7 @@ withServer serverExe f = do hSetBuffering serverErr NoBuffering errSinkThread <- forkIO $ forever $ hGetLine serverErr - pid <- fromIntegral . fromJust <$> getPid serverProc + pid <- getProcessID serverProc result <- f serverIn serverOut pid diff --git a/src/Language/Haskell/LSP/Test/Session.hs b/src/Language/Haskell/LSP/Test/Session.hs index d12ed00..9782014 100644 --- a/src/Language/Haskell/LSP/Test/Session.hs +++ b/src/Language/Haskell/LSP/Test/Session.hs @@ -91,7 +91,7 @@ data SessionState = SessionState type ParserStateReader a s r m = ConduitParser a (StateT s (ReaderT r m)) -type SessionProcessor = ConduitT FromServerMessage FromServerMessage (StateT SessionState (ReaderT SessionContext IO)) +type SessionProcessor = ConduitM FromServerMessage FromServerMessage (StateT SessionState (ReaderT SessionContext IO)) runSession :: Chan FromServerMessage -> SessionProcessor () -> SessionContext -> SessionState -> Session a -> IO (a, SessionState) runSession chan preprocessor context state session = runReaderT (runStateT conduit state) context -- 2.30.2